Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

This code looks like it validates that the auto_reset argument is True, False, "yes", "no", or None:

        if not auto_reset or auto_reset is None or auto_reset == "no":
            self._auto_reset = "no"
        elif auto_reset or auto_reset == "yes":
            self._auto_reset = "yes"
        else:
            raise ValueError(f"Unsupported value for `auto_reset` {auto_reset}")

But in fact the else clause will never trigger, because all falsy values will trigger the first branch, and all truthy values (except "no") will trigger the second branch. So the else clause is dead code.

And if the user provides "False" or "No", the code will silently set self._auto_reset to "yes"

This PR limits acceptable values to True, False, "yes", "no", or None

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

• Existing tests apply
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Checklist

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A